On Wed, Apr 23, 2014 at 12:47 AM, Junio C Hamano <gits...@pobox.com> wrote: > "brian m. carlson" <sand...@crustytoothpaste.net> writes: >> What we could do instead is simply require a newer version of >> Getopt::Long, which would let people continue using their ancient OSes >> and install a newer version from CPAN if necessary. It's also the >> proper way to specify the dependency. > > Yes, but if its inability to properly grok --option="" is the only > reason we want to add a dependency, wouldn't it suffice to simply > state in the documentation (1) how to recognise the symptom to see > if the version the user has is too old, e.g. "if you see this error > message", "run 'perl -v' to see if your perl is older than X", > etc. and (2) how to work it around, i.e. "instead of giving an empty > value with --option='', say --option ''"?
FWIW, the least intrusive approach is what I find most agreeable: - Fix the tests to use --prefix "" instead of --prefix="" - Update the documentation like Junio suggests above. - Reformat an example using --prefix "" I.e. use Kyle's patch to t9117, plus something like this: diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt index 5b3c38d..9f579e0 100644 --- a/Documentation/git-svn.txt +++ b/Documentation/git-svn.txt @@ -91,6 +91,9 @@ COMMANDS NOTE: Before Git v2.0, the default prefix was "" (no prefix). This meant that SVN-tracking refs were put at "refs/remotes/*", which is incompatible with how Git's own remote-tracking refs are organized. +If you still want the old default, you can get it by passing +'--prefix ""' on the command line ('--prefix=""' may not work if +your Perl's Getopt::Long is < v2.37). --ignore-paths=<regex>;; When passed to 'init' or 'clone' this regular expression will ...Johan -- Johan Herland, <jo...@herland.net> www.herland.net -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html