Junio C Hamano wrote: > Felipe Contreras <felipe.contre...@gmail.com> writes: > > > Junio C Hamano wrote: > >> Felipe Contreras <felipe.contre...@gmail.com> writes: > >> > >> > This hook is invoked before a branch is updated, either when a branch is > >> > created or updated with 'git branch', or when it's rebased with 'git > >> > rebase'. It receives three parameters; the name of the branch, the > >> > SHA-1 of the latest commit, and the SHA-1 of the first commit of the > >> > branch. > >> > > >> > When a branch is created the first and last commits of the branch are > >> > the same, however when a branch is rebased they are not. If the SHA-1 of > >> > the first commit of the branch is not available (e.g. git reset) a null > >> > SHA-1 (40 zeroes) would be passed. > >> > > >> > The hook exit status can be used to deny the branch update. > >> > > >> > It can be used to verify the validity of branch names, and also to keep > >> > track of the origin point of a branch, which is otherwise not possible > >> > to find out [1]. > >> > >> Please call it pre-update-branch at least, > > > > I will do so when I see a good argument for it. > > If you choose to ignore "a user cannot tell from the name > update-branch when it will be called, we cannot introduce > post-update-branch later without making things more inconsistent if > we do not name it pre-something" and label them not "a good > argument", then I do not have anything to say to you.
I did not ignore it, it's an invalid argument, and I explained why. You are the one making the assumption that there will be a post-udpate-branch without actually providing any reasoning *why* we would want such a hook. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
