On Sat, Apr 26, 2014 at 2:13 PM, Jeff King <p...@peff.net> wrote:
> [+cc Duy, whose patch this is]
> On Fri, Apr 25, 2014 at 04:10:49PM -0400, Jörn Engel wrote:
>> A second option is to add a --pager (or rather --no-pager) option to
>> the command line and allow the user to specify
>>     GIT_PAGER="git --no-pager -p column --mode='dense color'" git -p branch
> I think we have "--no-pager" already. But the "-p" is turning _on_ the
> pager, so you could also just omit it. IOW, I really don't understand
> why the original command was not simply:
>   GIT_PAGER="git column --mode='dense color'" git -p branch
> The whole infinite loop that the original commit solved is caused by
> specifying the "-p". So it sounds like the right solution is "don't do
> that". Am I missing something useful that the "-p" does?

The intent of the commit was "that is a stupid thing to do, but it's
not so obvious from the first glance, do not freeze my system for my
mistake". But if it stops an actual use case, then I agree it should
be reverted.

> I wonder if perhaps the intent was that the user might have set
> "pager.column", in which case the use of the pager is implied. I still
> think that the right solution is to use "--no-pager" explicitly then. If
> the user is invoking git inside GIT_PAGER, it is up to them to save
> themselves from infinite recursion.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to