On 05/03/2014 10:12 PM, brian m. carlson wrote: > Signed-off-by: brian m. carlson <sand...@crustytoothpaste.net> > --- > combine-diff.c | 54 +++++++++++++++++++++++++++--------------------------- > diff-lib.c | 10 +++++----- > diff.h | 5 +++-- > 3 files changed, 35 insertions(+), 34 deletions(-) > > diff --git a/combine-diff.c b/combine-diff.c > index 24ca7e2..f97eb3a 100644 > --- a/combine-diff.c > +++ b/combine-diff.c > [...]
This file also has two literal "40" constants in it that are probably GIT_OID_HEXSZ. FWIW, I glanced over all of the patches in this series (though without systematically looking for other literal constants that should be derived from GIT_OID_RAWSZ and GIT_OID_HEXSZ) and, aside from the problems that I already noted, they looked OK to me. Michael -- Michael Haggerty mhag...@alum.mit.edu http://softwareswirl.blogspot.com/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
