On Tue, May 13, 2014 at 09:07:12AM -0700, Jonathan Nieder wrote:
> Jeremiah Mahler wrote:
> > # from a string
> > $ git format-patch --signature "from a string" origin
> > # or from a file
> > $ git format-patch --signature ~/.signature origin
> Interesting. But... what if I want my patch to end with
> ? It seems safer to introduce a separate --signature-file option.
It is probably smarter to avoid that corner case entirely.
> > builtin/log.c | 26 ++++++++++++++++++++++++--
> > 1 file changed, 24 insertions(+), 2 deletions(-)
I added a test which checks that a valid patch is produced and that
the signature from the file appears in the output.
> Thanks and hope that helps,
In addition to addressing the suggestions from Jonathan I also
updated the Documentation.
This solution uses a static buffer to store the signature which does
create a size limitation (1024 bytes). I considered a solution
using malloc but I could not figure out a clean way of determining when
to free the memory.
Thanks for the help and suggestions.
Jeremiah Mahler (1):
format-patch --signature-file <file>
Documentation/git-format-patch.txt | 7 +++++++
builtin/log.c | 24 ++++++++++++++++++++++++
t/t4014-format-patch.sh | 13 +++++++++++++
3 files changed, 44 insertions(+)
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html