On 5/19/2014 2:44 AM, Erik Faye-Lund wrote:
On Mon, May 19, 2014 at 9:13 AM, Johannes Sixt <j.s...@viscovery.net>
wrote:
I'm not proficient enough to add any ACL fiddling to fchmod that
would be required by the above change, whose purpose is to be
strict about permissions. Nor am I interested (who the heck is
sharing a Windows box anyway? ;-)


Since we use MSVCRT's chmod implementation directly which only
checks for S_IWRITE,and Get/SetFileAttributes to simply set or clear
the FILE_ATTRIBUTE_READONLY-flag, perhaps we could do the same
except using Get/SetFileInformationByHandle instead? That takes us in
a better direction, IMO. Adding full ACL support seems like a bigger
project.

If there's no objection, I'll sketch up a patch for that...

IMO, try to stay away from full ACL support, as ACL is slow as hell.
If it's only triggered in edge cases, that's fine, but be sure not to add any ACL in the main call-paths as it will surely kill performance.

The major speedup which was done by circumventing MSYS/Cygwin standard posix implementations was bypassing much of the ACL slowness.

--
.marius
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to