On Tue, May 20, 2014 at 08:06:50AM -0700, Junio C Hamano wrote:
> Jeff King <p...@peff.net> writes:
> > You could do:
> > #define DEFAULT_SIGNATURE git_version_string
> > static const char *signature = DEFAULT_SIGNATURE;
> > ...
> > if (signature == DEFAULT_SIGNATURE)
> > ...
> > but maybe that is getting a little unwieldy, considering the scope of
> > the original problem.
> I agree. It is an invitation for doing something like
> #define DEFAULT_SIGNATURE "-- \nfoo bar\n"
> which defeats the purpose.
> I have an unrelated and larger design level suggestion, but it may
> be better for me to refrain from sending it during the -rc freeze.
I will take DEFAULT_SIGNATURE out of the next patch revision.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html