On Wed, May 21, 2014 at 12:42:55PM -0400, Jeff King wrote: > On Tue, May 20, 2014 at 11:46:51AM -0700, Junio C Hamano wrote: > > > Jeff King <p...@peff.net> writes: > > > > > If it were just "--signature", I'd agree. After all, nobody is even > > > complaining. But this is also in preparation for --signature-file. > > > Should the user create a file without a trailing newline? > > > > Ahh, I missed that part. > > > > I am fine with processing it with stripspace(). > > I wasn't planning on anything as drastic as stripspace. I really just > wanted to suppress the one newline, which is almost certainly the right > thing to include for "--signature", but the wrong thing for > "--signature-file" (i.e., the patch I posted earlier). > > Stripspace() would drop all extra whitespace, and I wondered if people > would _want_ it in their sigs (e.g., a blank line after the "-- " but > before their .sig content). > > I dunno. Maybe it is not worth caring too much about. I don't want to > hold up Jeremiah's patch for something that I suspect neither of us > cares _that_ much about (I know I am not planning on using > --signature-file myself). I just don't want to deal with a patch later > that says "oh, this spacing is wrong" and have to respond "yes, but we > have to retain it so as not to break existing users". > > > By the way, at some point we may want to move that helper function > > to strbuf.c, but that is a separate issue. > > Agreed. I was touching some string functions earlier today and noticed > that strbuf.c actually contains a lot of non-strbuf functions for > dealing with C strings. That's fine, I guess, but I also wondered if we > should have a separate file for C-string functions. I suppose it doesn't > matter that much either way, as long as it's in a libgit.a file (and > stripspace currently is _not_, which I assume is what you were > indicating above). > > -Peff
I am fine with including your previous patch. Would like me to test it out and create another patch set? -- Jeremiah Mahler jmmah...@gmail.com http://github.com/jmahler -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
