Ramsay Jones <ram...@ramsay1.demon.co.uk> writes: > On 21/05/14 14:20, Alexey Shumkin wrote: >> Pretty format string %<(N,[ml]trunc)>%s truncates subject to a given >> length with an appropriate padding. This works for non-ASCII texts when >> i18n.logOutputEncoding is UTF-8 only (independently of a printed commit >> message encoding) but does not work when i18n.logOutputEncoding is NOT >> UTF-8. >> >> There were no breakages as far as were no tests for the case >> when both a commit message and logOutputEncoding are not UTF-8. >> >> Add failing tests for that which will be fixed in the next patch. >> >> Signed-off-by: Alexey Shumkin <alex.crez...@gmail.com> >> Reviewed-by: Nguyễn Thái Ngọc Duy <pclo...@gmail.com> >> Reviewed-by: Ramsay Jones <ram...@ramsay1.demon.co.uk> > > Hmm, I didn't really review these patches. I simply noted a problem > on my system and provided you with an extended bug-report and > assisted you in fixing it up. So, if it even warrants a mention in > the commit message, then 'Helped-by:' would be nearer the mark.
I had the same impression. The same for Duy's. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html