On Thu, May 22, 2014 at 05:36:12AM -0400, Jeff King wrote: > If we do want to do magic like "latin1 is really iso-8859-1", that seems > like the domain of iconv to me. If iconv doesn't handle it itself, I'd > rather have a wrapper there. Putting it at that layer keeps the code > cleaner, and it means the wrapper would benefit the regular commit-log > reencoding code.
I think being a little stricter in our character encoding actually benefits users. If someone claims that all their commit messages are in US-ASCII or ISO-8859-1, and then stuffs Windows-1252 in there, that's going to break a lot of stuff, especially if someone assumes US-ASCII means it's okay to use it where UTF-8 is required. It's much better to let people not insert broken stuff in the first place rather than deal with it afterwards. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Description: Digital signature