>From signal(2)

  The behavior of signal() varies across UNIX versions, and has also var‐
  ied historically across different versions of Linux.   Avoid  its  use:
  use sigaction(2) instead.  See Portability below.

Replaced signal() with sigaction() in connect.c

Signed-off-by: Jeremiah Mahler <jmmah...@gmail.com>
 connect.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/connect.c b/connect.c
index a983d06..b2a33c9 100644
--- a/connect.c
+++ b/connect.c
@@ -665,11 +665,14 @@ struct child_process *git_connect(int fd[2], const char 
        enum protocol protocol;
        const char **arg;
        struct strbuf cmd = STRBUF_INIT;
+       struct sigaction sa;
        /* Without this we cannot rely on waitpid() to tell
         * what happened to our children.
-       signal(SIGCHLD, SIG_DFL);
+       memset(&sa, 0, sizeof(sa));
+       sa.sa_handler = SIG_DFL;
+       sigaction(SIGCHLD, &sa, 0);
        protocol = parse_connect_url(url, &hostandport, &path);
        if (flags & CONNECT_DIAG_URL) {

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to