On Tue, May 27, 2014 at 5:27 PM, Jonathan Nieder <jrnie...@gmail.com> wrote:
> Hi,
> Comments from http://marc.info/?l=git&m=140079653930751&w=2:
> Ronnie Sahlberg wrote:
>> [Subject: update-ref.c: log transaction error from the update_ref]
> The above description suggests that this is going to add new logging,
> or in other words that update_ref was being silent about transaction
> errors before.
> The actual intent is for there to be no functional change, right?  I'd
> say something like "update-ref: use err argument to get error from
> ref_transaction_commit" or something similar to make it clearer that
> this is just about changing APIs.  Or if there's an intended
> functional change, then the commit message could say something about
> that.

I reworded the commit message.

> Thanks,
> Jonathan
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to