Jeff King <p...@peff.net> writes: > On Fri, May 30, 2014 at 09:55:14AM -0700, Junio C Hamano wrote: > > I don't think we need to worry about commit->buffer being mucked with. > It is always either NULL, or points to the original object contents. > Encoded log messages are always placed in a separate buffer (and in fact > we use the same "optionally point to commit->buffer" trick there). And > things like mucking with parents always happen on the parsed form. > > Of course I may be missing a site, and it's certainly a maintenance risk > for the future. But I'd go so far as to say that anything modifying > commit->buffer is wrong, and that side should be fixed.
I fully agree, and "that side should be fixed" implying "we should always be on a look-out for such a change" is something the lazyness tried to avoid. > Do you want me to roll it up with a real commit message? Yes. I think the change is sensible. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
