I have the problem that the overridden test_cmp crashes on a couple of places
where it is doing a binary compare, so this is definitely needed.
I actually used cmp -q in my override as it's the return code that is most
On Wed, 4 Jun 2014 11:22:56 AM Junio C Hamano wrote:
> Stepan Kasal <ka...@ucw.cz> writes:
> > test_cmp() is primarily meant to compare text files (and display the
> > difference for debug purposes).
> > Raw "cmp" is better suited to compare binary files (tar, zip, etc.).
> > On MinGW, test_cmp is a shell function mingw_test_cmp that tries to
> > read both files into environment, stripping CR characters (introduced
> > in commit 4d715ac0).
> > This function usually speeds things up, as fork is extremly slow on
> > Windows. But no wonder that this function is extremely slow and
> > sometimes even crashes when comparing large tar or zip files.
> > Signed-off-by: Stepan Kasal <ka...@ucw.cz>
> > ---
> > Hi Thomas,
> > On Wed, Jun 04, 2014 at 02:59:44PM +0200, Thomas Braun wrote:
> >> Using test_cmp_bin instead of cmp would result in then four assertions
> >> for comparing arbitrary data
> >> test_cmp
> >> test_i18ncmp
> >> test_cmp_text
> >> test_cmp_bin
> >> where I think the purpose of each function is clear from its name.
> > [test_cmp_text does not exist (yet)]
> > OK, I agree, hence this modified version of the patch.
> Yeah, I think the above reasoning is sound. And I do not think we
> ever need to have test_cmp_text -- our payload and our messages
> compared by tests to make sure our expectations hold are text by
> Will queue; thanks.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html