Am 05.06.2014 08:06, schrieb Heiko Voigt:
> This allows a reader to immediately know which options can be used and
> what this parameter is about.
> 
[...]
> -void hashmap_free(struct hashmap *map, int free_entries)
> +void hashmap_free(struct hashmap *map, enum hashmap_free_options 
> free_entries)
[...]
>  
> +enum hashmap_free_options {
> +     HASHMAP_NO_FREE_ENTRIES = 0,
> +     HASHMAP_FREE_ENTRIES = 1,
> +};

This was meant as a boolean parameter. Would it make sense to have

enum boolean {
        false,
        true
};

or similar in some central place?

Note that an earlier version took a function pointer, and you could pass 
stdlib's free() in the common case, or a special free routine for nested entry 
structures, or NULL to do the cleanup yourself.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to