From: Jeff King <p...@peff.net>
>
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> @@ -2313,7 +2313,7 @@ static struct commit *fake_working_tree_commit(struct 
> diff_options *opt,
>                   ident, ident, path,
>                   (!contents_from ? path :
>                    (!strcmp(contents_from, "-") ? "standard input" : 
> contents_from)));
> -     set_commit_buffer(commit, strbuf_detach(&msg, NULL));
> +     set_commit_buffer(commit, msg.buf, msg.len);

I find the above strange. I would have done something like:

-       set_commit_buffer(commit, strbuf_detach(&msg, NULL));
+       size_t size;
+       char *buf = strbuf_detach(&msg, &size);
+       set_commit_buffer(commit, buf, size);

Thanks,
Christian.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to