On Tue, Jun 10, 2014 at 02:40:30PM -0700, Junio C Hamano wrote:

> Jeff King <p...@peff.net> writes:
> 
> > Note that we may be fixing a bug here. The existing code
> > does:
> >
> >   if (same_encoding(to, from))
> >       reencode_string(buf, to, from);
> >
> > That probably should have been "!same_encoding".
> >
> > Signed-off-by: Jeff King <p...@peff.net>
> > ---
> > I didn't actually test for the bug, so it's possible that I'm missing
> > something clever...
> 
> Thanks for spotting.  There is nothing clever going on.
> 
> 0e18bcd5 (reencode_string(): introduce and use same_encoding(),
> 2012-10-18) has this misconversion.

Ah, thanks, I tried digging but didn't see anything obvious (and somehow
my eyes glossed over the s/same_encoding/strcmp/ while reading the
history). I feel much better about the change now.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to