"Michael S. Tsirkin" <m...@redhat.com> writes:

> I'm using different signature tags for git am depending on the patch,
> project and other factors.
> Sometimes I add multiple tags as well, e.g. QEMU
> wants both Reviewed-by and Signed-off-by tags.
> This patch makes it easy to do so:
> 1.  new parameter am.signoff can be used any number
>       of times:
> [am]
>       signoff = "Reviewed-by: Michael S. Tsirkin <m...@redhat.com>"
>       signoff = "Signed-off-by: Michael S. Tsirkin <m...@redhat.com>"
>       if set all signatures are picked up when git am -s is used.

How does this interact with the logic to avoid appending the same
Signed-off-by: line as the last one the incoming message already

> 2.  Any number of alternative signatures
> [am "a"]
>       signoff = "Acked-by: Michael S. Tsirkin <m...@redhat.com>"
>       if set the signature type can be specified by passing
>       a parameter to the -s flag:
>       git am -sa
> No docs or tests, sorry, so not yet ready for master, but I'm using this
> all the time without any issues so maybe ok for pu.
> Early flames/feedback/help welcome.

How does that "a" in [am "a"] work?  If it defines some kind of
scope (i.e. use am.a.* instead of am.* when I specify I am using "a"
set somehow), that might be something interesting, but if it applies
only to sign-off and other things, then I am not sure if I like it,
as that would invite confusions from end users.

> +             signoffs=("${signoffs[@]}" "${s[@]}") ;;

Is this a shell array?  It won't fly in our codebase if that is the

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to