Jeremiah, That looks great. Since I'm not seeing any more feedback on the code for this set of patches, I'll go ahead and send up another set.
Thank you for those pointers. Caleb Thompson On Thu, Jun 12, 2014 at 11:46:37AM -0700, Jeremiah Mahler wrote: > Caleb, > > On Thu, Jun 12, 2014 at 01:23:41PM -0500, Caleb Thompson wrote: > > Jeremiah, > > > > On Thu, Jun 12, 2014 at 11:04:59AM -0700, Jeremiah Mahler wrote: > > > > ... > > > > > > How are you preparing your patches. 'git format-patch' with a 'git > > > send-email'? > > > > I'm so glad you asked, because I've just been muddling through this. > > > > I've been generating the cover page variously with request-pull or diff > > --stat, then running a command like this, with --cc arguments added from > > a list I've been keeping of people who respond to the threads: > > > > git send-email --compose --email@example.com --thread \ > > [--cc ...] --no-chain-reply origin/master... > > > > Then I manually edit the subjects to add the version to the [PATCH N/M] > > portions. I haven't been using format-patch. > > > > It's interesting that only the first patch isn't applying. I'd love to > > hear a better way. > > > > Caleb > > It sounds like you are doing too much work. > > After I make a series of commits I run format-patch. This example has 2 > patches (-2). I like --thread, although it seems to work fine without > it. And --reroll-count will automatically do your N/M numbering for > you. It also generates a cover letter which you can then edit by hand. > All the patches will be named v3-* in this case. > > git format-patch --reroll-count=3 --cover --thread -2 > > Then I can send the whole patch series using send-email. > > git send-email --to=caleb --cc=git --cc=junio v3-* > > Felipe Contreras has a good writeup  on how to setup aliases with Mutt so > you don't have to type the full email every time. > > : http://felipec.wordpress.com/2009/10/25/git-send-email-tricks/ > > I recently setup Mutt with Offlineimap  and Msmtp. This is an > awesome setup too. Not patch related, but it makes the email part > easier. > > : https://wiki.archlinux.org/index.php/OfflineIMAP > > -- > Jeremiah Mahler > jmmah...@gmail.com > http://github.com/jmahler
Description: PGP signature