On Mon, Jun 09, 2014 at 04:22:50PM -0700, Junio C Hamano wrote:

> Two test scripts (t3302 and t3419) had copy & paste code to set
> USR_BIN_TIME prerequisite.  Use the test_lazy_prereq helper to define
> them in the common t/test-lib.sh.

I have to wonder why we even have such a prereq in the first place.

Many tests which use EXPENSIVE are sensible; we used to do something bad
with large values, we fixed it, and want to be able to test the
correctness of the fix. The use in t0021 looks like that.

However, the tests in t3302 and t3419, which use both EXPENSIVE and
USR_BIN_TIME, seem like they are really interested in performance
testing. I think they probably should be in t/perf in the first place
(the reason they are not is presumably because they predate it).

Other than that, your series looks fine.


PS s/expesive/expensive/ in the commit message of 7/7
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to