Jeff King <p...@peff.net> writes:
>> for commit in initial second merge fourth-signed fifth-signed
>> sixth-signed master
>> - git show --pretty=short --show-signature $commit
>> >actual &&
>> + git show --pretty=short --show-signature $commit
>> >actual || exit 1
>> grep "Good signature from" actual || exit 1
> Hrm. The original is:
> X &&
> Y || exit 1
> Won't that still exit (i.e., it is already correct)? Doing:
> for X in true false; do
> for Y in true false; do
> ($X && $Y || exit 1)
> echo "$X/$Y: $?"
> true/true: 0
> true/false: 1
> false/true: 1
> false/false: 1
> (and should still short-circuit Y, because we go from left-to-right).
> I do not mind changing it to keep the style of each line consistent,
> though. I would have written it as a series of "&&"-chains, with a
> single exit at the end, but I think that is just a matter of preference.
Yeah, series of && chain with a single exit at the end is good, and
the subshell is there only to allow us to do that "exit at the end".
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html