On Tue, Jun 17, 2014 at 02:37:45PM -0700, Junio C Hamano wrote:
> Jeff King <p...@peff.net> writes:
> > On Tue, Jun 17, 2014 at 02:39:00PM -0500, Caleb Thompson wrote:
> >> diff --git a/t/t7507-commit-verbose.sh b/t/t7507-commit-verbose.sh
> >> index 35a4d06..471bd8f 100755
> >> --- a/t/t7507-commit-verbose.sh
> >> +++ b/t/t7507-commit-verbose.sh
> >> @@ -7,6 +7,10 @@ write_script check-for-diff <<-'EOF'
> >> exec grep '^diff --git' "$1"
> >> EOF
> >> +write_script check-for-no-diff <<-'EOF'
> >> + ! check-for-diff
> >> +EOF
> > Don't you need "$PWD/" or similar here, since check-for-diff is not in our
> > path?
> I actually would prefer a simpler
> ! grep '^diff --git' "$1"
> that does not depend on what other parts of the tests have done.
Yeah, if it is that simple, I would agree (I did not even look at the
definition of check-for-diff, and assumed it was more complicated :) ).
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html