Am 21.06.2014 00:33, schrieb Junio C Hamano:
> Karsten Blees <karsten.bl...@gmail.com> writes:
> 
>> To be able to add a common prefix or suffix to all trace output (e.g.
>> a timestamp or file:line of the caller), factor out common setup and
>> cleanup tasks of the trace* functions.
>>
>> Some unit-tests use trace output to verify internal state, and variable
>> output such as timestamps and line numbers are not useful there. Disable
>> additional trace output if GIT_TRACE_BARE is set.
> 
> Hmph, this makes me wonder if we are better off making these
> additional trace output optional, i.e. not disabling with
> GIT_TRACE_BARE like this, but show the new output only when
> explicitly asked for by setting GIT_TRACE_PERF or something.
> 

GIT_TRACE_VERBOSE perhaps? It affects all trace output, not just
GIT_TRACE_PERFORMANCE. The tests would still have to disable it
explicitly, though, in case someone sets it in their profile.

However, IIRC conclusion of v4 discussion was that this would be
useful for all trace output [1], so I think it should be the default.

[1] https://groups.google.com/forum/#!topic/msysgit/UMKTvmZX5aI

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to