On Sun, Jun 22, 2014 at 12:51 PM, Michael S. Tsirkin <m...@redhat.com> wrote:
> Why did it auto-pack twice in a single pull?
> None of the changes applied are very large.
>
> Guess: auto-packing was started in background, did not
> complete in time, and was restarted for the second time?
> If true, some kind of lock file would be useful
> to prevent this.

There is a lock, $GIT_DIR/gc.pid. However we are prepared to deal with
stale locks, and may have slipped somehow. The test is in
builtin/gc.c, lock_repo_for_gc(). Oh wait, we check for lock (and exit
if lock exists) _after_ we print the message (in cmd_gc). That might
be it.. If it so, maybe we can reorder some code to prevent this bogus
message, but has to be careful and do it before daemonizing..
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to