Jeff King <p...@peff.net> writes:
> On Wed, Jun 25, 2014 at 10:20:13AM -0700, Junio C Hamano wrote:
>> Jeff King <p...@peff.net> writes:
>> > Here's a replacement patch that handles this (and just drops the ugly
>> > mallocs as a side effect).
>> > -- >8 --
>> > Subject: [PATCH] setup_git_env: copy getenv return value
>> > The return value of getenv is not guaranteed to survive
>> > across further invocations of setenv or even getenv. When we
>> > are assigning it to globals that last the lifetime of the
>> > program, we should make our own copy.
>> > Signed-off-by: Jeff King <p...@peff.net>
>> > ---
>> Sigh. This mail unfortunately crossed with 64f25581 (Merge branch
>> into next, 2014-06-23) with about 20 hours of lag.
> Ah, sorry. I had checked yesterday that jk/xstrfmt hadn't been merged
> yet, but I didn't check when responding to Duy.
Sorry to have sighed --- crossing e-mails happen all the time. No
need to feel sorry.
>> I'd make it relative like the attached on top of the series. Note
>> that I tweaked the args to git_pathdup() to avoid the "are you sure
>> you want to give a variable format string to git_pathdup() which you
>> said is like printf(3)?" warning from the compiler.
> Both changes look good to me. Thanks for taking care of it.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html