Karsten Blees <karsten.bl...@gmail.com> writes:

> Am 28.06.2014 08:01, schrieb Matthieu Moy:
>> Karsten Blees <karsten.bl...@gmail.com> writes:
>>> I still don't like that the invalidation is done in git_config_set, though, 
>>> as
>>> this is also used to write completely unrelated files.
>> I don't get it. It is used to write the config files. Yes, we trigger a
>> complete reload instead of just changing this particular value in the
>> hashmap, but I do not see "unrelated files" in the picture.
> git-cherry-pick, revert: writes '.git/sequencer/opts' (sequencer.c:save_opts)
> git-mv <submodule>: writes '.gitmodules' 
> (submodule.c:update_path_in_gitmodules)
>   ...and the submodule's '.git/config' 
> (submodule.c:connect_work_tree_and_git_dir)

In the previous patch series, the cache was only about the system, user
and repo config files. So, .git/sequencer/opts, .gitmodules are totally
independant. In the latest series, there's a new notion of config_set.
.gitmodules, .git/sequencer/opts and the usual config files are in
different config sets, and their cache is invalidated independently.

Matthieu Moy
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to