On 07/02/2014 08:17 PM, Junio C Hamano wrote:
Avi Kivity <a...@cloudius-systems.com> writes:

+               if test 't' == "$message_id"
+               then
+                       grep ^Message-Id: "$dotest/info" || true
+               fi
                if test '' != "$ADD_SIGNOFF"
                        echo "$ADD_SIGNOFF"
Seeing how existing code carefully makes sure that ADD_SIGNOFF has
an empty line before it when and only when necessary to ensure that
there is a blank after the existing log message, I would suspect
that this patch that blindly inserts a line is doubly wrong.  The
output from "grep" may be appended without adding a blank when
necessary, and appending of ADD_SIGNOFF may end up adding an extra
blank after Message-Id.  Am I reading the patch wrong?

Yes, you're right. Will have to redo the logic for deciding whether we already have a tag stanza or not.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to