Heiko Voigt <hvo...@hvoigt.net> writes: > diff --git a/builtin/checkout.c b/builtin/checkout.c > index 07cf555..03ea20d 100644 > --- a/builtin/checkout.c > +++ b/builtin/checkout.c > @@ -18,6 +18,7 @@ > #include "xdiff-interface.h" > #include "ll-merge.h" > #include "resolve-undo.h" > +#include "submodule-config.h" > #include "submodule.h" > #include "argv-array.h" >
Hmph. What is this change about? Nobody in checkout.c needs anything new, yet we add a new include? > diff --git a/diff.c b/diff.c > index f72769a..f692a3c 100644 > --- a/diff.c > +++ b/diff.c > @@ -13,6 +13,7 @@ > #include "utf8.h" > #include "userdiff.h" > #include "sigchain.h" > +#include "submodule-config.h" > #include "submodule.h" > #include "ll-merge.h" > #include "string-list.h" Likewise. It is somewhat unclear to me what real change that improves the life of end-users this series brings to us. The "test-submodule-config" test program obviously is new but that does not really count until we see real uses. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
