On Thu, Jul 10, 2014 at 03:33:47PM +1000, Sam McLeod wrote:

> 'For already up-to-date repos return "Already up-to-date" which is the
> same message git pull returns.'

Please send your patches inline as a single body part, as generated by
"git format-patch" (you can use git-send-email to send).

> Developer's Certificate of Origin 1.1

You can drop the DCO here. Your Signed-off-by line is enough.

> diff --git a/builtin/send-pack.c b/builtin/send-pack.c
> index f420b74..6fb2642 100644
> --- a/builtin/send-pack.c
> +++ b/builtin/send-pack.c
> @@ -274,7 +274,7 @@ int cmd_send_pack(int argc, const char **argv, const char 
> *prefix)
>       }
>       if (!ret && !transport_refs_pushed(remote_refs))
> -             fprintf(stderr, "Everything up-to-date\n");
> +             fprintf(stderr, "Already up-to-date\n");

Hrm. So this makes things consistent with git-pull, but despite the
names, push and pull are not actually opposites. Push and fetch are
opposites. And fetch does not say anything in the up-to-date case.

So I'd somewhat wonder whether we should just be making "push" less
chatty here. Still, that is a much bigger change that some people might
disagree with, and I confess I don't care overly (but nor did the
Everything/Already ever bother me either :) ).

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to