On 7/11/2014 7:51 PM, Matthieu Moy wrote: >> +`int git_configset_add_file(struct config_set *cs, const char *filename)`:: >> + >> + Parses the file and adds the variable-value pairs to the `config_set`, >> + dies if there is an error in parsing the file. > > The return value is undocumented. > > If I read correctly, the only codepath from this to a syntax error sets > die_on_error, hence "dies if there is an error in parsing the file" is > correct. > > Still, there are errors like "unreadable file" or "no such file" that do > not die (nor emit any error message, which is not very good for the > user), and lead to returning -1 here. > > I'm not sure this distinction is right (why die on syntax error and > continue running on unreadable file?). >
I checked the whole codebase and in all of the cases if they cannot read a file they return -1 and continue running. So, I have updated the API to document the return value. I think if the file is unreadable. we must continue running as no harm has been done yet, worse is parsing a file with wrong syntax which can cause reading wrong config values. So the decision to die on syntax error sounds alright to me. Cheers, Tanay Abhra. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
