[PATCH v10]: Minor fixes according to [12]. Re added string_list initializer 
        Thanks to Junio and Matthieu for their suggestions.

[PATCH v9]: Applied most of the review comments mentioned in [11]. Mostly 
asthetic changes.
        test-config now clears the config_set before exiting. Most of the tests 
now use the
        check-config function. check_config_init() now handles return values 
        Diff between v8 and v9 is at the bottom. Thanks to Junio and Matthieu 
for the review.

[PATCH V8]: Moved the contents of config-set.c to config.c for future 
convenience. Reverted
        test 'find value with misspelled key' to the one in v5. See [10] for 
the discussion.

[PATCH V7]: Style nits and a broken && chain corrected in 
`t/t1308-config-set.sh`. See
        [9] for the nits.

[PATCH V6]: Style nits and mistakes corrected. Diff between v6 and v5[8] is at 
the bottom.
                Thanks to Matthieu, Ramsay and Ram for their suggestions.

[PATCH V5]: `config_set` now uses a single hashmap. Corrected style nits raised 
                        the thread[7]. Thanks to Junio and Matthieu for their 

[PATCH v4]: Introduced `config_set` construct which points to a ordered set of
        config-files cached as hashmaps. Added relevant API functions. For more
        details see the documentation. Rewrote the git_config_get* family to use
        `config_set` internally. Added tests for both config_set API and 
        family. Added type specific API functions which parses the found value 
        converts it into a specific type.
        Most of the changes implemented are the result of discussion in [6].
        Thanks to Eric, Ramsay, Junio, Matthieu & Karsten for their suggestions
        and review.

[PATCH v3]: Added flag for NULL values that were causing segfaults in some 
        Added test-config for usage examples.
        Minor changes and corrections. Refer to discussion thread[5] for more 
        Thanks to Matthieu, Jeff and Junio for their valuable suggestions.

[PATCH v2]:Changed the string_list to a struct instead of pointer to a struct.
        Added string-list initilization functions.
        Minor mistakes corrected acoording to review comments[4]. Thanks to
        Eric and Matthieu for their review.

[PATCH V1]:Most of the invaluable suggestions by Eric Sunshine, Torsten 
Bogershausen and
        Jeff King has been implemented[1]. Complete rewrite of config_cache*() 
        using git_config() as hook as suggested by Jeff. Thanks for the review.

[RFC V2]: Improved according to the suggestions by Eric Sunshine and Torsten 
        Added cache invalidation when config file is changed.[2]
        I am using git_config_set_multivar_in_file() as an update hook.

This is patch is for this year's GSoC. My project is
"Git Config API improvements". The link of my proposal is appended below [3].

The aim of this patch series is to generate a cache for querying values from
the config files in a non-callback manner as the current method reads and
parses the config files every time a value is queried for.

The cache is generated from hooking the update_cache function to the current
parsing and callback mechanism in config.c. It is implemented as an hashmap
using the hashmap-api with variables and its corresponding values list as
its members. The values in the list are sorted in order of increasing priority.
The cache is initialised the first time when any of the new query functions is
called. It is invalidated by using git_config_set_multivar_in_file() as an
update hook.

We add two new functions to the config-api, git_config_get_string() and
git_config_get_string_multi() for querying in a non callback manner from
the cache.

[1] http://marc.info/?t=140172066200006&r=1&w=2
[4] http://thread.gmane.org/gmane.comp.version-control.git/251073/focus=251369
[5] http://thread.gmane.org/gmane.comp.version-control.git/251704/
[6] http://thread.gmane.org/gmane.comp.version-control.git/252329/
[7] http://marc.info/?t=140428115200001&r=1&w=2
[8] http://article.gmane.org/gmane.comp.version-control.git/252942/
[9] http://thread.gmane.org/gmane.comp.version-control.git/252959/
[10] http://article.gmane.org/gmane.comp.version-control.git/253113
[11] http://thread.gmane.org/gmane.comp.version-control.git/253248
[12] http://thread.gmane.org/gmane.comp.version-control.git/253562

Tanay Abhra (4):
  string-list: add string_list initialiser helper functions
  Use string-list initializaer functions to rewrite
  config set

 .gitignore                                  |   1 +
 Documentation/technical/api-config.txt      | 137 +++++++++++++++
 Documentation/technical/api-string-list.txt |   5 +
 Makefile                                    |   1 +
 builtin/commit.c                            |   3 +-
 cache.h                                     |  30 ++++
 config.c                                    | 263 ++++++++++++++++++++++++++++
 merge-recursive.c                           |   9 +-
 string-list.c                               |   6 +
 string-list.h                               |   2 +
 submodule.c                                 |   5 +-
 t/t1308-config-set.sh                       | 200 +++++++++++++++++++++
 test-config.c                               | 142 +++++++++++++++
 transport.c                                 |   4 +-
 14 files changed, 793 insertions(+), 15 deletions(-)
 create mode 100755 t/t1308-config-set.sh
 create mode 100644 test-config.c


To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to