On 7/24/2014 3:41 AM, Junio C Hamano wrote:
> Matthieu Moy <matthieu....@grenoble-inp.fr> writes:
> 
>> Tanay Abhra <tanay...@gmail.com> writes:
>>
>>> +test_expect_success 'check line errors for malformed values' '
>>> +   cp .git/config .git/config.old &&
> 
> Should this be "mv" not "cp"?  You will be overwriting the file from
> scratch in the later part of this test.
>

Noted.

>>> +   test_when_finished "mv .git/config.old .git/config" &&
>>> +   echo "[alias]\n br" >.git/config &&
> 
> Is the use of \n portable?
> 

Yes, you are right, will replace with printf in the next patch.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to