"patrick.reyno...@github.com" <patrick.reyno...@github.com> writes:

It seems you mixed your name and email address in your config file. I
guess your name is "Patrick Reynolds", not

> Remotes are stored as an array, so looking one up or adding one without
> duplication is an O(n) operation.  Reading an entire config file full of
> remotes is O(n^2) in the number of remotes.  For a repository with tens of
> thousands of remotes, the running time can hit multiple minutes.

Just being curious: in which senario do you have tens of thousands of

(not an objection, it's a good thing anyway)

> +static inline void init_remotes_hash()

static inline void init_remotes_hash(void)

Not a detailed review, but the patch sounds good other than that.

Matthieu Moy
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to