Tanay Abhra <tanay...@gmail.com> writes:
> Signed-off-by: Tanay Abhra <tanay...@gmail.com>
I think I deserve a bit of credit here ;-).
> - return git_config_with_options(fn, data, NULL, 1);
> + if (git_config_with_options(fn, data, NULL, 1) < 0)
> + /*
> + * git_config_with_options() normally returns only
> + * positive values, as most errors are fatal, and
> + * non-fatal potential errors are guarded by "if"
> + * statements that are entered only when no error is
> + * possible.
> + *
> + * If we ever encounter a non-fatal error, it means
> + * something went really wrong and we should stop
> + * immediately.
> + */
> + die("Unknown error occured while reading the configuration
My bad, but this should be die(_("..."));, so that the message can be
translated. Not really serious since it's not really meant to be seen by
the user, though.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html