Jeff King <p...@peff.net> writes:
> On Mon, Aug 04, 2014 at 05:45:44PM +0200, Matthieu Moy wrote:
>> Tanay Abhra <tanay...@gmail.com> writes:
>> > `git_pretty_formats_config()` continues without checking
>> > git_config_string's
>> > return value which can lead to a SEGFAULT.
>> Indeed, without the patch:
>> $ git -c pretty.my= log --pretty=my
>> error: Missing value for 'pretty.my'
>> zsh: segmentation fault git -c pretty.my= log --pretty=my
> Hmm. Not related to the original patch, but that really looks like a
> bug. Shouldn't "git -c pretty.my= ..." set pretty.my to the empty string?
> I'd expect "git -c pretty.my ..." to set it to NULL (i.e., the "implicit
> true" you get from omitting the "=" in the config files themselves).
strbuf_split_buf() does not seem to distinguish between x= and x. No
time to debug this further, sorry.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html