On Aug 6, 2014, at 6:22 AM, Steffen Prohaska <proha...@zib.de> wrote:

> On Aug 4, 2014, at 9:03 PM, Junio C Hamano <gits...@pobox.com> wrote:
>>> +   return apply_filter(path, 0, 0, -1, 0, ca.drv->clean);
>> What's the significance of "-1" here?  Does somebody in the
>> callchain from apply_filter() check if fd < 0 and act differently
>> (not a complaint nor rhetoric question)?
> The decision in apply_filter() to return before the real work is
> taken on the first 0.

Hmm..., actually it's the last 0 that matters.  If no destination buffer
is given, apply_filter() returns whether it would filter or not.

>  Any value for fd would be ok.  The -1 is
> only a reminder that the fd is invalid.


To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to