On Sun, Aug 17, 2014 at 5:25 PM, Steffen Prohaska <proha...@zib.de> wrote:
>
> On Aug 17, 2014, at 9:27 AM, Jeff King <p...@peff.net> wrote:
>
>> On Sat, Aug 16, 2014 at 06:26:08PM +0200, Steffen Prohaska wrote:
>>
>>>> Is the 15MB limit supposed to be imposed somewhere or is it just a guide
>>>> of how much memory we expect Git to use in this scenario?
>>>
>>> The test should confirm that the the file that is added is not mmapped
>>> to memory.  The process size should be relatively small independently
>>> of the size of the file that is added.  I wanted to keep the file size
>>> small.  The chosen sizes worked for me on Mac and Linux.
>>
>> Measuring memory usage seems inherently a bit flaky for the test suite.
>> It's also a little out of place, as the test suite is generally about
>> correctness and outcomes, and this is a performance issue.
>
> For files >2GB on a 32-bit system (e.g. msysgit), filtering with the previous 
> code always failed.  Now it works.  I created the patch to change git from 
> 'fundamentally doesn't handle this' to 'works as expected'.

I deal with similar problem and added $GIT_ALLOC_LIMIT to test large
blob code. Maybe we could add $GIT_MMAP_LIMIT? I don't suppose we call
xmmap/xmalloc so often that the extra test would slow git down.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to