Am 30.08.2014 21:30, schrieb David Aguilar:
> Use `git rev-parse --quiet` instead of redirecting to /dev/null.
>
> Signed-off-by: David Aguilar <[email protected]>
> ---
> git-stash.sh | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/git-stash.sh b/git-stash.sh
> index bcc757b..5a5185b 100755
> --- a/git-stash.sh
> +++ b/git-stash.sh
> @@ -50,7 +50,7 @@ clear_stash () {
> then
> die "$(gettext "git stash clear with parameters is
> unimplemented")"
> fi
> - if current=$(git rev-parse --verify $ref_stash 2>/dev/null)
> + if current=$(git rev-parse --quiet --verify $ref_stash)
> then
> git update-ref -d $ref_stash $current
> fi
> @@ -67,7 +67,7 @@ create_stash () {
> fi
>
> # state of the base commit
> - if b_commit=$(git rev-parse --verify HEAD)
> + if b_commit=$(git rev-parse --quiet --verify HEAD)
> then
> head=$(git rev-list --oneline -n 1 HEAD --)
> else
The else branch calls die; wouldn't it be useful to keep the error
message of rev-parse?
> @@ -292,7 +292,7 @@ save_stash () {
> }
>
> have_stash () {
> - git rev-parse --verify $ref_stash >/dev/null 2>&1
> + git rev-parse --quiet --verify $ref_stash
This change is not correct: --quiet removes only output on stderr, but
not that on stdout.
> }
>
> list_stash () {
> @@ -392,12 +392,12 @@ parse_flags_and_rev()
> ;;
> esac
>
> - REV=$(git rev-parse --quiet --symbolic --verify "$1" 2>/dev/null) || {
> + REV=$(git rev-parse --quiet --symbolic --verify "$1") || {
> reference="$1"
> die "$(eval_gettext "\$reference is not valid reference")"
> }
>
> - i_commit=$(git rev-parse --quiet --verify "$REV^2" 2>/dev/null) &&
> + i_commit=$(git rev-parse --quiet --verify "$REV^2") &&
> set -- $(git rev-parse "$REV" "$REV^1" "$REV:" "$REV^1:" "$REV^2:"
> 2>/dev/null) &&
I see another rev-parse that you did not modify. An omission?
> s=$1 &&
> w_commit=$1 &&
> @@ -409,7 +409,7 @@ parse_flags_and_rev()
> test "$ref_stash" = "$(git rev-parse --symbolic-full-name "${REV%@*}")"
> &&
> IS_STASH_REF=t
>
> - u_commit=$(git rev-parse --quiet --verify "$REV^3" 2>/dev/null) &&
> + u_commit=$(git rev-parse --quiet --verify "$REV^3") &&
> u_tree=$(git rev-parse "$REV^3:" 2>/dev/null)
I see yet another rev-parse that you did not modify.
> }
>
> @@ -531,7 +531,7 @@ drop_stash () {
> die "$(eval_gettext "\${REV}: Could not drop stash entry")"
>
> # clear_stash if we just dropped the last stash entry
> - git rev-parse --verify "$ref_stash@{0}" >/dev/null 2>&1 || clear_stash
> + git rev-parse --quiet --verify "$ref_stash@{0}" || clear_stash
Again not correct.
> }
>
> apply_to_branch () {
>
-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
