Jeff King wrote: > From: Ronnie Sahlberg <[email protected]> > > lock_ref_sha1_basic is inconsistent about when it calls > die() and when it returns NULL to signal an error. This is > annoying to any callers that want to recover from a locking > error.
And in addition to the modern transaction stuff, rename_ref() has been such a caller for a long time. Thanks for a pleasant explanation. Reviewed-by: Jonathan Nieder <[email protected]> [...] > Signed-off-by: Ronnie Sahlberg <[email protected]> > Signed-off-by: Jonathan Nieder <[email protected]> No need for my sign-off here --- it was just an artifact of my forwarding the patch to the list before. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
