On Tue, Jan 6, 2015 at 10:57 AM, Junio C Hamano <[email protected]> wrote:
> You said it yourself above, didn't you? While perfecting your
> branch and while perfecting reroll of your branch.
>
>
>> * After doing changes, wait at least 12 hours for second self-review
>
> This is certainly once-per-series.
Right.
>
>> * sending out:
>> git format-patch --cover-letter --notes --subject-prefix=PATCHvX
>
> This is not even helpful reminder if that is only shown after you
> run format-patch, no?
Right, as I currently have these notes somewhere completely
out of reach of my git tree, I manually check that list whenever I need to.
So this is for different events.
>
> Yes, but that is a separate discussion where the check list is given
> (per patch or per series?) and how it is presented (overriding the
> "blurb here" comment or something else that can also be used for the
> non-cover messages?).
One of the problems here may be that a single patch is never formatted
as a patch, but lives inside the git world. Only when I consider the
whole series
good I start formatting the patches, which is why it's hard to find a place on
a per-patch basis.
>>> Perhaps --add-header="x-reminder: what changed since the last?"
>>> would be sufficient for your purpose instead?
Maybe a similar approach of pre writing notes to some per patch
checklist would do?
So once I'd set
git config commit.add_notes_if_empty "/in/filesystem/checklist/per/patch"
which would add notes whenever I'd commit and the notes for that commit
are not empty (i.e. commit --amend doesn't wipe existing notes).
Maybe that config option should rather be below
notes.add_on_commit though.
So before we drift into more discussion, I'd still think it makes sense to have
the ***BLURB *** replaced by some configurable questions regarding the
series as a whole, so I'd try to perfect that patch?
Thanks,
Stefan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
