Re: [PATCH 1/3] connect.c: Fix memory leak

[Torsten Bögershausen]

On 2015-03-09 17.58, Stefan Beller wrote:
> Signed-off-by: Stefan Beller <sbel...@google.com>
> ---
>  connect.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/connect.c b/connect.c
> index ce0e121..6090211 100644
> --- a/connect.c
> +++ b/connect.c
> @@ -739,6 +739,7 @@ struct child_process *git_connect(int fd[2], const char 
> *url,
>  
>                               free(hostandport);
>                               free(path);
> +                             free(conn);
>                               return NULL;
>                       } else {
>                               ssh = getenv("GIT_SSH_COMMAND");
> 
Nice catch, thanks.
(Even if it is not sooo serious today, the current implementation of Git just 
dies
when connection is NULL)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html