Trevor Saunders <[email protected]> writes:
> Signed-off-by: Trevor Saunders <[email protected]>
> ---
> The test change only kind of tests the change in behavior and doesn't seem all
> that useful. However I'm not sure if its preferable to not even try and test
> that something isn't output.
As the only objective of this patch is to stop showing that raw
format diff output, I think it is sensible to make sure that the
output no longer happens.
I have a feeling that this patch has some backstory? It may be
necessary to summarize it in the log message to explain why this is
a good thing to do.
> diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh
> index 06b4868..eb820b2 100755
> --- a/t/t6030-bisect-porcelain.sh
> +++ b/t/t6030-bisect-porcelain.sh
> @@ -591,7 +591,8 @@ test_expect_success 'test bisection on bare repo -
> --no-checkout defaulted' '
> "test \$(git rev-list BISECT_HEAD ^$HASH2 --max-count=1
> | wc -l) = 0" \
> >../defaulted.log
> ) &&
> - grep "$HASH3 is the first bad commit" defaulted.log
> + grep "$HASH3 is the first bad commit" defaulted.log &&
> + test 0 -eq $(grep -c '^:' defaulted.log)
> '
Your single quotes around the pattern are not doing what you think
they are doing.
Why not write this line like this instead?
! grep "^:" default.log
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
