Junio C Hamano <gits...@pobox.com> writes: > Is this sufficient? > If you are going to do something in 2/2 that relies on the format of > this line being correct (as opposed to "noop" or "#" that can have > any garbage on the remainder of the line), wouldn't you want to at > least check $sha1 is sensible?
That's also something that I was wondering, I wrote about it in the 0/2 part of this patch, I wanted some opinion about it. If there is no opposition on the subject, I will have it ready for the v3 of the patch. Quote of that part of the 0/2 for more clarity: Galan Rémi <remi.galan-alfo...@ensimag.grenoble-inp.fr> writes: > For the 'drop' command, maybe instead of just doing the same thing as > noop, checking if the SHA-1 that supposedly follow does exist could be > a good idea. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
