Paul Tan <pyoka...@gmail.com> writes:

>     
>     * Yup, I did mean strcmp(value, "only")

I may be missing some backstory behind this comment; in the patch, I
instead see !strcmp(value, "only") and I think it makes sense.

> +     if (git_config_get_value("pull.ff", &value))
> +             return;
> +     switch (git_config_maybe_bool("pull.ff", value)) {
> +             case 0:
> +                     strbuf_addstr(sb, "--no-ff");
> +                     return;

Align switch and case at the same indent level; the body of switch
is overindented.

> +             case 1:
> +                     strbuf_addstr(sb, "--ff");
> +                     return;
> +     }
> +     if (!strcmp(value, "only")) {
> +             strbuf_addstr(sb, "--ff-only");
> +             return;
> +     }
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to