On Fri, Jun 12, 2015 at 03:14:25PM -0700, Junio C Hamano wrote: > "brian m. carlson" <sand...@crustytoothpaste.net> writes: > > > While I did run the tests between each commit, I hadn't noticed they > > were failing because I don't have Apache installed on my laptop, so they > > were silently skipped. I'll resubmit with that fixed. > > It is somewhat strange that _only_ http part had failures like this, > and is unnerving, too, given that a few people seem to have given at > least a cursory read over the patches and didn't spot anything > obviously wrong. > > Was that because there was a single manual botch, or was that merely > that other parts of the system do not have sufficient test coverage?
It appears that I broke the change in "parse_fetch: convert to use struct object_id" which modifies remote-curl.c, so I think it's a single manual botch. I'm going to rework that patch anyway since Michael said that he didn't like the idea of parse_oid_hex as it stands, so it will end up being mostly moot. I mostly introduced it in an effort to avoid having to use GIT_SHA1_HEXSZ repeatedly throughout small blocks of code, but since we don't use assignments in conditionals, it doesn't seem useful as it currently stands. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
signature.asc
Description: Digital signature
