Michael Haggerty <[email protected]> writes:

> +     struct ref_transaction *t;
> +     struct strbuf err = STRBUF_INIT;
> +
> +     t = ref_transaction_begin(&err);
> +     if (!t)
> +             die(err.buf);

Yikes, and sorry for sending three messages without consolidating
against the same patch, but

        die("%s", err.buf);

because

extern NORETURN void die(const char *err, ...) __attribute__((format (printf, 
1, 2)));

in its declaration causes -Werror=format-security to barf.

Likewise for a few other instances of the same construct all in 
the same file.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to