On Mon, Jun 29, 2015 at 1:32 PM, Stefan Beller <sbel...@google.com> wrote: > On Sun, Jun 28, 2015 at 7:06 AM, Paul Tan <pyoka...@gmail.com> wrote: >> + tz = tz / (60 * 60) * 100 + tz % (60 * 60); > > What happens if we have a negative input not matching a full hour, say -5400 ? > (would equate to 0130 in git) > > for calculating the minutes we would only need to take % 3600 (which > you do), but > then we still need to divide by 60 to convert seconds to minutes? >
That said, I wonder if we have some helper functions around somewhere as we need to convert the timezone data at many places. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html