On Wed, Jul 1, 2015 at 1:01 AM, Paul Tan <pyoka...@gmail.com> wrote: > On Tue, Jun 30, 2015 at 7:51 AM, Stefan Beller <sbel...@google.com> wrote: >> I needed to read this patch a few times as this patch introduces >> `sign_commit` >> twice. This is mostly a review problem I'd guess as in the code it >> just affects this >> method and you'd see all the code of the method easily compared to hunks sent >> via email. But renaming this variable doesn't hurt. > > OK. What variable name do you want? Would "gpgsign" (to match > commit.gpgsign) do?
Fine with me. Thanks, Stefan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
