On Wed, Jul 8, 2015 at 9:16 PM, Matthieu Moy <[email protected]> wrote: > Karthik Nayak <[email protected]> writes: > >> On Wed, Jul 8, 2015 at 2:37 PM, Matthieu Moy >> <[email protected]> wrote: >>> Torsten Bögershausen <[email protected]> writes: >>> >>>> Could we have a tweak for people without gpg? >>> >>> I guess we need stg like >>> >>> if ! test_have_prereq GPG; then >>> skip_all='skipping for-each-ref tests, gpg not available' >>> test_done >>> fi >>> >>> since we need GPG in the setup test and almost all other tests will rely >>> on it. >>> >> >> Does this need to be there? I see a lot of test files which need GPG, and >> since >> this test file contains tests which rely on it, without it, it would >> be kinda useless >> anyways? > > In many cases, the tests look like > > . lib-gpg.sh > > test_expect_success 'test that does not use GPG' ' > ... > ' > > test_expect_success GPG 'test that does use GPG' ' > ... > ' > > so you can't decide in lib-gpg.sh that you'll skip all tests, because > you would skip some tests that could be ran without gpg. >
Ah! Thanks. Will reply here with your fix included :) -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
