From: "Eric Sunshine" <[email protected]>
On Sun, Jul 19, 2015 at 4:08 PM, Philip Oakley <[email protected]> wrote:Keep the build clean of extraneous files if it is indeed clean. Otherwise leave the msvc-build-makedryerrors.txt file both as a flag for any CI system or for manual debugging.Note that the file will contain the new values of the GIT_VERSION and GITGUI_VERSION if they were generated by the make file. They are omitted if the release is tagged and indentically defined in their respective GIT_VERSION_GEN file DEF_VER variables. Signed-off-by: Philip Oakley <[email protected]> ---diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.plindex a6999b6..020776e 100755 --- a/contrib/buildsystems/engine.pl +++ b/contrib/buildsystems/engine.pl @@ -77,6 +77,8 @@ EOM my $ErrsFile = "msvc-build-makedryerrors.txt";@makedry = `cd $git_dir && make -n MSVC=1 V=1 2>$ErrsFile` if !@makedry;+# test for an empty Errors file and remove it +for ($ErrsFile) {unlink $_ if (-f $_) && (!-s $_);}Why the 'for' loop? Also, if you're using the 'for' loop for the $_ side-effect, then why not the simpler:
It was cargo cult programming, with some Google searching to select between invocations. Most examples were looping through lists in scripts, hence the down select.
for ($ErrsFile) { unlink if -f && !-s; }
A lot better. Will fix.
?# Parse the make output into usable info parseMakeOutput(); -- 2.4.2.windows.1.5.gd32afb6
-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
